Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare MoveIt! Jacobian against KDL #2377

Merged
merged 2 commits into from Sep 26, 2023

Conversation

marioprats
Copy link
Contributor

Description

Adds the KDL Jacobian to the MoveIt Jacobian benchmark to have a baseline. As it is today, MoveIt! Jacobian is already ~2x faster than KDL.

------------------------------------------------------------
Benchmark                  Time             CPU   Iterations
------------------------------------------------------------
BM_MoveItJacobian        558 ns          558 ns      1251060
BM_KDLJacobian          1013 ns         1014 ns       686766

This change adds a dependency from robot_state to kdl_parser, but robot_core already depends on KDL, so I think this should be ok?

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I think the kdl_parser as test dependency should be fine 👍

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (94fea79) 50.74% compared to head (f97af83) 50.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2377      +/-   ##
==========================================
+ Coverage   50.74%   50.74%   +0.01%     
==========================================
  Files         386      386              
  Lines       31970    31970              
==========================================
+ Hits        16219    16220       +1     
+ Misses      15751    15750       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henningkayser henningkayser merged commit 53303d6 into moveit:main Sep 26, 2023
8 checks passed
m-elwin pushed a commit to m-elwin/moveit2 that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants