[Servo] Set static parameters as read-only
#2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahiminfinite
changed the title
read-onlyread-only
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2381 +/- ##
==========================================
- Coverage 50.74% 50.71% -0.02%
==========================================
Files 386 386
Lines 31970 31970
==========================================
- Hits 16219 16211 -8
- Misses 15751 15759 +8 ☔ View full report in Codecov by Sentry. |
sea-bass
reviewed
Sep 23, 2023
AndyZe
reviewed
Sep 23, 2023
ibrahiminfinite
commented
Sep 24, 2023
Co-authored-by: AndyZe <andyz@utexas.edu>
sea-bass
reviewed
Sep 24, 2023
sea-bass
approved these changes
Sep 25, 2023
AndyZe
approved these changes
Sep 25, 2023
m-elwin
pushed a commit
to m-elwin/moveit2
that referenced
this pull request
Dec 4, 2023
* Make some params read-only + grouping * Apply suggestions from code review Co-authored-by: AndyZe <andyz@utexas.edu> * Allow dynamic initialization of velocity scales --------- Co-authored-by: AndyZe <andyz@utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2367
Many parameters in servo should not be changed during runtime.
This PR sets such parameters as read-only through the generate_parameter_library.
The parameters have also been grouped in a more meaningful manner.
Ping: @sea-bass @AndyZe