Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pre-commit-config.yaml #2382

Closed
wants to merge 5 commits into from
Closed

Update .pre-commit-config.yaml #2382

wants to merge 5 commits into from

Conversation

mosfet80
Copy link

@mosfet80 mosfet80 commented Sep 23, 2023

Updated codespell

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e2b8ac2) 50.84% compared to head (cba0a64) 50.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2382   +/-   ##
=======================================
  Coverage   50.84%   50.84%           
=======================================
  Files         386      386           
  Lines       31938    31938           
=======================================
  Hits        16237    16237           
  Misses      15701    15701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marioprats
Copy link
Contributor

Looks like the new version is catching a bunch of new spelling issues.
Would you mind fixing them as part of this PR so that the checks pass?
If you can't please let me know and I'll take it over. Thanks!

@marioprats marioprats assigned mosfet80 and unassigned marioprats Oct 11, 2023
@marioprats
Copy link
Contributor

Here's a link to the issues found by the format check: https://github.com/ros-planning/moveit2/actions/runs/6453757742/job/17517921805?pr=2382#step:5:181

@Shobuj-Paul
Copy link
Contributor

Shobuj-Paul commented Oct 23, 2023

This has already been fixed by #2465
Sorry @mosfet80 , didn't notice this PR before putting mine in.

Just a suggestion, usually a better way to update pre-commit is to run pre-commit autoupdate, this updates all the hooks in the yaml file rather than having to checking versions and updating them manually.

@marioprats
Copy link
Contributor

Thanks @mosfet80 and @Shobuj-Paul!
I'm closing this PR then.

@marioprats marioprats closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants