Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "test_time_optimal_trajectory_generation" unit test #241

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Aug 10, 2020

Enable missing unit test in moveit_core package as part of #216

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #241 into master will increase coverage by 2.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   46.63%   49.10%   +2.47%     
==========================================
  Files         122      122              
  Lines       12740    12740              
==========================================
+ Hits         5941     6256     +315     
+ Misses       6799     6484     -315     
Impacted Files Coverage Δ
...cessing/src/time_optimal_trajectory_generation.cpp 74.58% <0.00%> (+74.58%) ⬆️
...ry_processing/time_optimal_trajectory_generation.h 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbcc9e...9521655. Read the comment docs.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works just like that on Foxy, nice! Please rebase, then lgtm

@henningkayser henningkayser merged commit ef203e9 into moveit:master Aug 17, 2020
@sjahr sjahr deleted the enable_core_unit_test branch October 6, 2020 13:11
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants