Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(moveit_py) Extend Trajectory Execution Manager #2442

Open
MatthijsBurgh opened this issue Oct 12, 2023 · 5 comments
Open

(moveit_py) Extend Trajectory Execution Manager #2442

MatthijsBurgh opened this issue Oct 12, 2023 · 5 comments
Labels
enhancement New feature or request persistent Allows issues to remain open without automatic stalling and closing.

Comments

@MatthijsBurgh
Copy link
Contributor

MatthijsBurgh commented Oct 12, 2023 •
edited by sjahr

The trajectory execution manager is added partially to moveit_py (#2406). It is still missing the following interfaces, which are provided by the CPP interface:

  • getTrajectories
  • execute
  • executeAndWait
  • waitForExecution
  • getCurrentExpectedTrajectoryIndex
  • getLastExecutionStatus
  • getControllerManagerNode

As these interfaces are missing, doesn't mean all these interfaces should be implemented. That decision is still open to the developers.
@MatthijsBurgh MatthijsBurgh added the enhancement New feature or request label Oct 12, 2023
@bhavuk2002
Copy link

!assign me

@bhavuk2002
Copy link

exactly what you expect and what should i do?

@github-actions GitHub Actions
Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Nov 27, 2023
@MatthijsBurgh
Copy link
Contributor Author

@sjahr @peterdavidfagan can we add a label to this issue? So GH actions doesn't close it.

@sjahr sjahr added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Nov 27, 2023
JensVanhooydonck added a commit to JensVanhooydonck/moveit2 that referenced this issue Dec 2, 2023
@JensVanhooydonck
(moveit_py) Extend Trajectory Execution Manager
b497278 
Added part of the functions from moveit#2442
@JensVanhooydonck JensVanhooydonck mentioned this issue Dec 2, 2023
Merged
6 tasks
@JensVanhooydonck
Copy link
Contributor

I've added part of the functions for what i needed at the moment.
TODO:

  • getTrajectories
  • getCurrentExpectedTrajectoryIndex
  • getControllerManagerNode

JensVanhooydonck added a commit to JensVanhooydonck/moveit2 that referenced this issue Dec 2, 2023
@JensVanhooydonck
(moveit_py) Extend Trajectory Execution Manager
398f2e9 
Added part of the functions from moveit#2442
sjahr pushed a commit that referenced this issue Dec 5, 2023
@JensVanhooydonck @MatthijsBurgh
(moveit_py) Extend Trajectory Execution Manager (#2569)
7ab329d 
* (moveit_py) Extend Trajectory Execution Manager
Added part of the functions from #2442

* PR-remarks

* Update moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp

Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>

* Update moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp

Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>

* Update planning.pyi - Removed unused import

* Fixes whitespace issues

---------

Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JensVanhooydonck @MatthijsBurgh @sjahr @bhavuk2002