Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default initializers in collision_common.h #2475

Merged
merged 2 commits into from Oct 24, 2023
Merged

Conversation

marioprats
Copy link
Contributor

Description

Updates structs in collision_common.h to use default initialization, instead of constructors.
This should be less error-prone and safer, since it ensures all atomic types have been initialized, but it also enables designated initialization, e.g.:

collision_detection::CollisionRequest request{ .contacts = true };

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26a8937) 50.35% compared to head (d56c1d0) 50.31%.
Report is 1 commits behind head on main.

❗ Current head d56c1d0 differs from pull request most recent head b6c975a. Consider uploading reports for the commit b6c975a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   50.35%   50.31%   -0.03%     
==========================================
  Files         390      390              
  Lines       31954    31937      -17     
==========================================
- Hits        16087    16066      -21     
- Misses      15867    15871       +4     
Files Coverage Δ
...lude/moveit/collision_detection/collision_common.h 74.42% <ø> (-9.45%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr enabled auto-merge (squash) October 24, 2023 16:07
@sjahr sjahr merged commit 606722e into moveit:main Oct 24, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants