Fix trajectory execution manager comments for docs builds #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
added
the
backport-iron
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2563 +/- ##
==========================================
- Coverage 50.86% 50.48% -0.37%
==========================================
Files 388 387 -1
Lines 32253 32078 -175
==========================================
- Hits 16401 16192 -209
- Misses 15852 15886 +34 ☔ View full report in Codecov by Sentry. |
Abishalini
approved these changes
Dec 1, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
(cherry picked from commit bddab3f) # Conflicts: # moveit_py/src/moveit/moveit_ros/trajectory_execution_manager/trajectory_execution_manager.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the new additions to the
moveit_pypackage in #2406 caused docs build failures because it's not happy with underscores.Anyways, the original comments shouldn't point to a private member variable, but rather the ROS parameter that it is set from.
Confirmed this fixes docs builds and the
htmlproofercheck in the MoveIt 2 tutorials on my end.