Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LMA kinematics plugin #2595

Merged
merged 3 commits into from Dec 12, 2023
Merged

Remove LMA kinematics plugin #2595

merged 3 commits into from Dec 12, 2023

Conversation

sjahr
Copy link
Collaborator

@sjahr sjahr commented Dec 11, 2023

Description

As discussed earlier, this PR removes the LMA kinematics plugin. MoveIt2 offers multiple other and better alternatives. This PR is part of efforts to reduce the maintenance burden of moveit2 and to make it easier to change things in the future without the need to update barely used features.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2a3b16) 50.85% compared to head (a92f1e6) 50.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
- Coverage   50.85%   50.64%   -0.20%     
==========================================
  Files         388      387       -1     
  Lines       32360    32201     -159     
==========================================
- Hits        16453    16305     -148     
+ Misses      15907    15896      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr
Copy link
Collaborator Author

sjahr commented Dec 12, 2023

Failing test is the flaky servo one 😓

@tylerjw tylerjw merged commit a787972 into moveit:main Dec 12, 2023
10 of 12 checks passed
@tylerjw tylerjw deleted the pr-remove_lma branch December 12, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants