Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Ruckig with MoveIt1 #2596

Merged
merged 4 commits into from Dec 12, 2023
Merged

Sync Ruckig with MoveIt1 #2596

merged 4 commits into from Dec 12, 2023

Conversation

AndyZe
Copy link
Contributor

@AndyZe AndyZe commented Dec 11, 2023 •
edited

Description

Sync with the MoveIt1 commits given in the commit messages.

@AndyZe AndyZe marked this pull request as draft December 11, 2023 18:18
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7e8431a) 50.46% compared to head (89a6be2) 50.47%.

Files Patch % Lines
...rajectory_processing/src/ruckig_traj_smoothing.cpp 62.50% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2596      +/-   ##
==========================================
+ Coverage   50.46%   50.47%   +0.01%     
==========================================
  Files         387      387              
  Lines       32183    32185       +2     
==========================================
+ Hits        16238    16241       +3     
+ Misses      15945    15944       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndyZe AndyZe marked this pull request as ready for review December 11, 2023 19:45
sjahr
sjahr approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AndyZe AndyZe merged commit b2a3b16 into moveit:main Dec 12, 2023
12 checks passed
@AndyZe AndyZe deleted the ruckig_updates branch December 12, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjahr sjahr sjahr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndyZe @sjahr