Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collision_detection dependency on pluginlib #2638

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

clalancette
Copy link
Contributor

It is included by src/collision_plugin_cache.cpp, so it should be set as a dependency.

Description

Add a target_dependency from collision_detection to pluginlib, which is required for building. This should fix the build on Rolling: https://build.ros2.org/view/Rbin_uJ64/job/Rbin_uJ64__moveit_core__ubuntu_jammy_amd64__binary/166/

Checklist

  • [N/A] Required by CI: Code is auto formatted using clang-format
  • [N/A] Extend the tutorials / documentation reference
  • [N/A] Document API changes relevant to the user in the MIGRATION.md notes
  • [N/A] Create tests, which fail without this PR reference
  • [N/A] Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

It is included by src/collision_plugin_cache.cpp, so it should be set as a dependency.
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (978bd4c) 51.00% compared to head (bb0d6bd) 51.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2638      +/-   ##
==========================================
+ Coverage   51.00%   51.01%   +0.01%     
==========================================
  Files         387      387              
  Lines       32308    32308              
==========================================
+ Hits        16476    16479       +3     
+ Misses      15832    15829       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr merged commit be8d3eb into main Jan 3, 2024
14 checks passed
@sjahr sjahr deleted the clalancette/collision-pluginlib-dep branch January 3, 2024 08:44
@clalancette
Copy link
Contributor Author

Thank you for merging! If you get a chance, a new release of MoveIt into Rolling will help fix the build regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants