Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] export cmake library install #339

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Jan 21, 2021

Signed-off-by: Tyler Weaver tylerjw@gmail.com

Description

This fixes the same issue I fixed here: moveit/srdfdom#76

With this pull request you can now build with --symlink-install and use moveit2 in an overlay without build errors.

Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
@tylerjw tylerjw added this to In progress in Sprint 00 via automation Jan 21, 2021
@tylerjw tylerjw changed the title [fix] export cmake likbrary install [fix] export cmake library install Jan 21, 2021
@bostoncleek
Copy link
Contributor

Looks good 👍

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #339 (d3b9239) into main (c933c88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files         157      157           
  Lines       14874    14874           
=======================================
  Hits         7124     7124           
  Misses       7750     7750           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c933c88...d3b9239. Read the comment docs.

Sprint 00 automation moved this from In progress to Reviewer approved Jan 22, 2021
@JafarAbdi JafarAbdi merged commit d41811b into moveit:main Jan 22, 2021
Sprint 00 automation moved this from Reviewer approved to Done Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants