Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove move_group namespace #420

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

vatanaksoytezer
Copy link
Contributor

@vatanaksoytezer vatanaksoytezer commented Apr 13, 2021

Related to #417, @JafarAbdi and I discussed and looked for solutions. We tried to add ~/ to the nodes though these result in a namespace of move_group_private which we thought would have to change and break quite a bit of stuff. So we thought to leave it the way it is right now and removed move_group namespaces from the relevant files. @henningkayser can you check if it makes sense, or we still want the private node stuff?

If you approve I will send a PR to moveit2_tutorials and moveit_resources related to this. I've tested this with run_move_group, run_moveit_cpp and quickstart rviz (didn't send a PR for this one yet) all seem to work fine.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #420 (07cd209) into main (855db9e) will decrease coverage by 0.08%.
The diff coverage is 45.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   53.04%   52.96%   -0.07%     
==========================================
  Files         212      212              
  Lines       22612    22622      +10     
==========================================
- Hits        11992    11980      -12     
- Misses      10620    10642      +22     
Impacted Files Coverage Δ
...bot_model/include/moveit/robot_model/robot_model.h 92.86% <ø> (ø)
...bot_state/include/moveit/robot_state/robot_state.h 88.89% <ø> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 61.64% <0.00%> (-1.00%) ⬇️
...ning/robot_model_loader/src/robot_model_loader.cpp 69.60% <51.22%> (-4.08%) ⬇️
moveit_core/robot_model/src/joint_model.cpp 47.28% <0.00%> (-3.63%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 81.14% <0.00%> (-1.25%) ⬇️
...anning_scene_monitor/src/current_state_monitor.cpp 55.90% <0.00%> (-0.43%) ⬇️
...cessing/src/time_optimal_trajectory_generation.cpp 90.28% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a476210...07cd209. Read the comment docs.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now to prevent irritations. We can change it back when re-enabling proper namespaces in a follow-up.

@vatanaksoytezer
Copy link
Contributor Author

This works for now to prevent irritations. We can change it back when re-enabling proper namespaces in a follow-up.

That sounds great! Thanks for checking up.

@henningkayser henningkayser merged commit feaa27c into moveit:main Apr 14, 2021
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Co-authored-by: AndyZe <zelenak@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants