Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robot_model & moveit_ros_visualization dependencies #421

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

JafarAbdi
Copy link
Contributor

Description

The ros2 build is failing because it can't find angles.h for the robot_model see, this PR fixes it & exports rviz_common rviz_default_plugins for moveit_ros_visualization

@henningkayser
Copy link
Member

I just saw that angles is only listed as a <test depend/> in the package.xml. Should be a <depend/> for the new joint model

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #421 (b97f4e1) into main (cd6ec43) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   52.96%   52.99%   +0.03%     
==========================================
  Files         212      212              
  Lines       22622    22622              
==========================================
+ Hits        11980    11986       +6     
+ Misses      10642    10636       -6     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 56.11% <0.00%> (-0.12%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 81.14% <0.00%> (+0.63%) ⬆️
.../ompl_interface/src/detail/constrained_sampler.cpp 59.46% <0.00%> (+16.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6ec43...b97f4e1. Read the comment docs.

@JafarAbdi JafarAbdi merged commit 25cbb0e into moveit:main Apr 16, 2021
@JafarAbdi JafarAbdi deleted the pr-fix_dependencies branch April 16, 2021 05:29
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants