Clang-tidy fixes #596
Merged
Clang-tidy fixes #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjw
reviewed
Aug 17, 2021
There was a problem hiding this comment.
Looks like clang isn't installed in the ci environment by default. You will need to use the ADDITIONAL_DEPS feature of industrial_ci
henningkayser
force-pushed
the
pr-fix_clang_ci
branch
from
21e29f0
to
e2fa0e8
Compare
Codecov Report
@@ Coverage Diff @@
## main #596 +/- ##
=======================================
Coverage 55.58% 55.58%
=======================================
Files 198 198
Lines 21420 21420
=======================================
Hits 11904 11904
Misses 9516 9516
Continue to review full report at Codecov.
|
JafarAbdi
approved these changes
Nov 21, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply moveit/moveit#2792I wanted to update this or get it closed. Of course, the changes to get clang enabled are already applied in the meantime. The fixes from the linked PR doesn't seem to be necessary, at least I didn't get any warnings locally using clang-10. However, I found other minor fixes that I added instead with this PR.