Kinematics base port to ROS 2 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahcorde
commented
May 16, 2019
ahcorde
commented
- Fixing logger variable
- Library as shared
- porting lookupParam function but it still need more work
@ahcorde Is this a work in progress or is it ready for review? |
|
@mlautman reworked! |
mlautman
reviewed
May 29, 2019
moveit_core/kinematics_base/include/moveit/kinematics_base/kinematics_base.h
Show resolved
Hide resolved
mlautman
reviewed
May 29, 2019
moveit_core/kinematics_base/include/moveit/kinematics_base/kinematics_base.h
Show resolved
Hide resolved
|
@mlautman did you review my comments? |
mlautman
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.