Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete backtrace hack #995

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Delete backtrace hack #995

merged 2 commits into from
Jan 17, 2022

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Jan 17, 2022

Description

We have backward_ros for this purpose and this code is used nowhere inside of moveit (included in one place but never used). We don't need a hack for printing the backtrace copied into moveit.

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #995 (f80915a) into main (877d0bd) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
+ Coverage   57.75%   57.78%   +0.04%     
==========================================
  Files         310      309       -1     
  Lines       26129    26120       -9     
==========================================
+ Hits        15087    15090       +3     
+ Misses      11042    11030      -12     
Impacted Files Coverage Δ
moveit_core/robot_state/src/robot_state.cpp 47.38% <ø> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.93% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877d0bd...f80915a. Read the comment docs.

@JafarAbdi JafarAbdi merged commit 4804ffa into moveit:main Jan 17, 2022
@tylerjw tylerjw deleted the delete_backtrace branch January 17, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants