Move background_processing #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #997 +/- ##
=======================================
Coverage 57.96% 57.96%
=======================================
Files 309 309
Lines 26120 26120
=======================================
Hits 15138 15138
Misses 10982 10982 Continue to review full report at Codecov.
|
henningkayser
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
background_processing is only used in one place (the rviz plugin), it is not a core feature of moveit and adds boost dependencies we'd like removed from moveit.
Long term the functionality of background_processing could be refactored to use features from the stdlib or replaced with async. In the short term though this is a nice reduction of code in moveit_core that doesn't belong in moveit_core.