Migrate to GitHub Actions [ros2] #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjw
force-pushed
the
ros2-github-actions
branch
2 times, most recently
from
30fcf79
to
ec8a335
Compare
tylerjw
force-pushed
the
ros2-github-actions
branch
from
ec8a335
to
265eaff
Compare
|
This is now ready for review. It is passing, see the link above. |
rhaschke
approved these changes
Mar 18, 2021
Comment on lines
-11
to
+13
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Wno-redundant-decls") | ||
| set(CMAKE_CXX_FLAGS | ||
| "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Wno-redundant-decls") |
There was a problem hiding this comment.
Which linter enforces this? ament_lint_cmake?
There was a problem hiding this comment.
yes, it enforces a 80 character line limit in cmake files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like many of my other PRs. This is a bunch of copy-pasta to convert us out of the infinite Travis queue.
Link to my fork where this is running for testing: https://github.com/tylerjw/moveit_msgs/pull/1/checks