migrate moveit_full_pr2 from ros-planning/moveit #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to resolve a circular package dependency (moveit/moveit#1111)
rhaschke
force-pushed
the
pr-rhaschke-fix-circular-dependencies
branch
from
ba6d2fa
to
c45caaa
Compare
130s
approved these changes
Oct 23, 2018
Looks like the indigo-devel branch of this repo is failing for ages on Travis: https://travis-ci.org/ros-planning/moveit_pr2/branches. Does anybody actively maintain this branch? |
That could mean the failing CI may not matter much, at least in the ROS distro release infrastructure. Since this PR is a blocker for moveit/moveit#1111 and ultimately moveit/moveit#1000, I'm merging this PR (then fix the failing CI separately). |
6 tasks
130s
added a commit
to 130s/rosdistro
that referenced
this pull request
Oct 24, 2018
This was referenced Oct 24, 2018
tfoote
pushed a commit
to ros/rosdistro
that referenced
this pull request
Oct 25, 2018
* [Indigo] Relocate moveit_full_pr2 repo (following moveit/moveit_pr2#98). * [I] Remove temporarily. Not entirely sure why CI failed, but I assume the version mismatch b/w the packages in the repo that the `moveit_full_pr2` is moved to. This change removes `moveit_full_pr2` pkg from the entire ROS distro land, but it'll soon be added back when release for `moveit_pr2` is made. https://travis-ci.org/ros/rosdistro/jobs/445789675 ``` ERROR: test.test_build_caches.test_build_caches ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/nose/case.py", line 197, in runTest self.test(*self.arg) File "/home/travis/build/ros/rosdistro/test/test_build_caches.py", line 57, in test_build_caches raise RuntimeError('\n'.join(errors)) RuntimeError: indigo: missing package.xml file for package "moveit_full_pr2" -------------------- >> begin captured logging << -------------------- rosdistro: DEBUG: Load index from "file:///home/travis/build/ros/rosdistro/index.yaml" rosdistro: DEBUG: Load cache from "http://repositories.ros.org/rosdistro_cache/indigo-cache.yaml.gz" rosdistro: DEBUG: Load file from "file:///home/travis/build/ros/rosdistro/indigo/distribution.yaml" rosdistro: DEBUG: Dropping release package XML cache for moveit_full_pr2 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate moveit_full_pr2 from moveit/moveit#1111 to resolve a circular package dependency.
moveit_full_pr2depends on:moveit_pr2->pr2_moveit_plugins->moveit_*Thus, this meta-package belongs here and not into the moveit repo.
Also cherry-pick this to kinetic-devel, replacing dependency to
moveit_fullin package.xml with actual packages?