Additional visualization #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add better PR title in the future |
davetcoleman
requested changes
Aug 22, 2018
src/moveit_visual_tools.cpp
Outdated
| if (!collision_obj.primitives[0].dimensions[shape_msgs::SolidPrimitive::BOX_Z]) | ||
| collision_obj.primitives[0].dimensions[shape_msgs::SolidPrimitive::BOX_Z] = rviz_visual_tools::SMALL_SCALE; | ||
|
|
||
| // ROS_INFO_STREAM_NAMED(name_,"CollisionObject: \n " << collision_obj); |
| @@ -347,6 +347,12 @@ class MoveItVisualTools : public rviz_visual_tools::RvizVisualTools | |||
| const std::string& name, | |||
| const rviz_visual_tools::colors& color = rviz_visual_tools::GREEN); | |||
|
|
|||
| bool publishCollisionCuboid(const Eigen::Affine3d& pose, double x, double y, double z, const std::string& name, | |||
There was a problem hiding this comment.
please add function documentation
davetcoleman
requested changes
Aug 22, 2018
| * \param pose - position of the centroid of the cube | ||
| * \param x - width | ||
| * \param y - depth | ||
| * \param z - height |
There was a problem hiding this comment.
the standard in this file is to call these variables width, depth, height - not x,y,z which imply position
mlautman
force-pushed
the
additional-vis
branch
from
1a05bba
to
d16e3cf
Compare
davetcoleman
approved these changes
Aug 23, 2018
davetcoleman
pushed a commit
that referenced
this pull request
Aug 23, 2018
* adding a visualization for publishing a box with width, height, and depth * adding additional publishCollisionCuboid method overloads * changing x,y,z to width, depth, height
|
cherry-picked to M |
|
@davetcoleman @mlautman Cherry-picking this to Melodic broke both this repo's melodic-branch as well as MoveIt's Travis (which is pulling in moveit_visual_tools via rosinstall file): Please fix. |
|
@rhaschke Working on it |
|
Just did a post-mortem with @mlautman and the takeaway is when doing direct cherry-picks between distros, check for anything TF related and if that is mentioned, do a full PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also ran clang formatting