Update hideRobot to hide visualized robot state by setting hide_display in DisplayRobotState msg #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay in DisplayRobotState msg
src/moveit_visual_tools.cpp
Outdated
| @@ -1517,22 +1517,14 @@ void MoveItVisualTools::publishRobotState(const moveit_msgs::DisplayRobotState& | |||
| ros::spinOnce(); | |||
| } | |||
|
|
|||
| bool MoveItVisualTools::hideRobot() | |||
| void MoveItVisualTools::hideRobot() | |||
There was a problem hiding this comment.
i don't see a reason to remove the bool and change API, please restore
There was a problem hiding this comment.
+1. Please, also restore the corresponding return value.
|
I forgot to mention this, but in this file we'll want to use code similar to this:
To disable when the msg flag is on |
rhaschke
reviewed
Aug 14, 2019
davetcoleman
approved these changes
Aug 15, 2019
rhaschke
approved these changes
Aug 15, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix #52 after pull request #55 get merged.
@davetcoleman
@henningkayser