[maint] add soname version #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4hn
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
LGTM.
One thing to point out about these changes is that they force users to recompile their whole workspace after each ROS package sync. However, we use this approach for MoveIt itself for quite some time now and no user actually objected - also because the alternative might be broken binaries you don't know about...
imho that seems like a much more annoying alternative |
|
On Wed, Aug 19, 2020 at 10:33:12AM -0700, Tyler Weaver wrote:
> the alternative might be broken binaries you don't know about
imho that seems like a much more annoying alternative
But it has been the quasi standard in ROS since the beginning. :-)
|
davetcoleman
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for a Noetic release. This is because Noetic is the last ROS1 version and it will enable us to increase the version of the library for future releases.