Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(AMCL)(Noetic) use robot pose in tests #1087

Merged

Conversation

MatthijsBurgh
Copy link
Contributor

@MatthijsBurgh MatthijsBurgh commented Jan 15, 2021

Melodic: #1088
Kinetic: #1089

@MatthijsBurgh MatthijsBurgh marked this pull request as draft January 17, 2021 11:27
@MatthijsBurgh MatthijsBurgh marked this pull request as ready for review January 18, 2021 11:06
@mikeferguson
Copy link
Contributor

Can you explain what this PR is doing a bit more?

@MatthijsBurgh
Copy link
Contributor Author

The AMCL tests used the pose of the odom frame instead of the base link. This required a big tolerance in one of the tests (check the xml files for removed comment).
This PR changes it to actually check the pose of base link.

Copy link
Contributor

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks for reviving a test that has been delisted for 8 years!

@mikeferguson mikeferguson merged commit de7637e into ros-planning:noetic-devel Jan 19, 2021
@MatthijsBurgh MatthijsBurgh deleted the fix/amcl_tests_noetic branch January 19, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants