Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set frame_id and stamp on Path message even if path is not found. #533

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Set frame_id and stamp on Path message even if path is not found. #533

merged 1 commit into from
Oct 28, 2016

Conversation

ledmonster
Copy link
Contributor

When path planning is failed, global planner publishes nav_msgs::Path without frame_id and stamp now. It causes error on rviz. Fix it to publish nav_msgs::Path with frame_id and stamp even if path planning was failed.

Before:

header: 
  seq: 24
  stamp: 
    secs: 0
    nsecs:         0
  frame_id: ''
poses: []

After:

header: 
  seq: 122
  stamp: 
    secs: 1477468563
    nsecs: 495041114
  frame_id: map
poses: []

@mikeferguson
Copy link
Contributor

I can't see any downside to this, but @DLu is there a reason that this initially had that if() block?

@DLu
Copy link
Member

DLu commented Oct 28, 2016

If there was, I don't remember it anymore.
+1

@DLu DLu merged commit 53087ca into ros-planning:kinetic-devel Oct 28, 2016
@ledmonster
Copy link
Contributor Author

Thank you!

Combinacijus pushed a commit to Combinacijus/navigation that referenced this pull request Mar 27, 2024
* updating docs for mppi_opt

* adding to migration guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants