Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package.xml] Add active maintainers. Much wrong info. #12

Merged
merged 2 commits into from
Aug 17, 2016

Conversation

130s
Copy link
Contributor

@130s 130s commented Aug 15, 2016

No description provided.

<author email="gwalck@techfak.uni-bielefeld.de">Guillaume Walck</author>
<maintainer email="isucan@willowgarage.com">Ioan Sucan</maintainer>
<maintainer email="isucan@gmail.com">Ioan Sucan</maintainer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just emailed @isucan to see if he wants to remain maintainer for packages like this, I'm fine either way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he suggested he be removed "from all instances" of package.xmls with him as a maintainer. I think we should also start a separate discussion on Discourse to find new active maintainers for all the packages - want to start that?

@davetcoleman
Copy link
Member

This is great, thanks!

[package.xml] Alphabetic order.
@130s
Copy link
Contributor Author

130s commented Aug 16, 2016

Comment addressed.

<build_depend>libconsole-bridge-dev</build_depend>
<build_depend>liburdfdom-headers-dev</build_depend>
<build_depend>rostest</build_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be a test_depend instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@130s
Copy link
Contributor Author

130s commented Aug 16, 2016

Comment addressed again.
Also noticed that pkg-config is not needed (see the commit message for the rationale).

@davetcoleman davetcoleman merged commit c351dac into moveit:indigo-devel Aug 17, 2016
@130s 130s deleted the fix/manifest branch August 17, 2016 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants