-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #33: Remove Boost, use C++11 #36
Resolves #33: Remove Boost, use C++11 #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a branch melodic-devel
. Can you, please, re-submit this PR targeting melodic-devel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhaschke I retargeted the request. Github allows for that since a year or so ✨
This is overdue and should have been in kinetic already. Thanks @IanTheEngineer !
I proposed a minor change.
include/srdfdom/trim.h
Outdated
@@ -0,0 +1,60 @@ | |||
// Copyright (c) 2017 Evan Teran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this header should be in the public interface of the package.
I propose to either put it into an anonymous namespace in src/model.cpp
(it's used only there atm)
or just move the file to src/
to avoid installing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this shouldn't be in the public interface. I'll move the file to the src/
directory as you and @rhaschke recommend.
I prefer this as it facilitates later reuse in another context. |
- Replaced boost::trim with C++11 lambda implementation of string trimming - Replaced all boost::shared_ptr with std::shared_ptr
c8d4a36
to
c9e7ea4
Compare
src/trim.h
Outdated
// String-Trimming Lambdas | ||
// Author: Evan Teran / evan-teran | ||
// URL: https://stackoverflow.com/a/217605 | ||
// MIT License Derived from Stack Overflow Policy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears I am mistaken on which license is required for code snippets from Stack Overflow. The whole discussion is rather heated and frankly, confusing, but it appears the license should be CC BY-SA 3.0. I believe BSD and CC are still compatible licenses, so I'll just update the license to CC.
More info on Stack Overflow Code Policy: https://meta.stackexchange.com/a/285723 License-copy text: https://creativecommons.org/2011/04/15/plaintext-versions-of-creative-commons-licenses-and-cc0/ Full License: https://creativecommons.org/licenses/by-sa/3.0/legalcode.txt
Hi @IanTheEngineer, |
@rhaschke I don't have a particularly strong opinion on using |
@rhaschke if things looks good, I can squash everything down into one commit. |
I agree Thanks @IanTheEngineer ! |
I think everyone agrees here already.
If Boost offers functions that simplify our code base, then feel free to use them.
There is no particular reason to remove them either, unless the standard offers equivalent solutions.
|
It may make sense to branch to
melodic-devel
prior to adding this commit.Replacedboost::trim
with C++11 lambda implementation of string trimmingboost::shared_ptr
withstd::shared_ptr
These changes were tested with all of the catkin tests provided, and passed.