Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rolling CI #85

Merged
merged 4 commits into from
May 22, 2021
Merged

Conversation

vatanaksoytezer
Copy link

Support rolling CI

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #85 (e591e14) into ros2 (e0f9bdb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             ros2      #85   +/-   ##
=======================================
  Coverage   68.21%   68.21%           
=======================================
  Files           3        3           
  Lines         607      607           
=======================================
  Hits          414      414           
  Misses        193      193           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f9bdb...e591e14. Read the comment docs.

@henningkayser
Copy link
Member

Could you add a pretty name tag similar to the moveit2 repo? Then lgtm

@vatanaksoytezer
Copy link
Author

Could you add a pretty name tag similar to the moveit2 repo? Then lgtm

I don't know what the pretty name tag is 😞 Can you point that out for me?

@henningkayser
Copy link
Member

Could you add a pretty name tag similar to the moveit2 repo? Then lgtm

I don't know what the pretty name tag is 😞 Can you point that out for me?

Something like this or what we just merged for random_numbers.

@vatanaksoytezer
Copy link
Author

Something like this or what we just merged for random_numbers.

Just added thanks!

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. Not that it matters too much, but I think we can remove ccov from rolling, it will be exactly the same report.

@henningkayser henningkayser merged commit 827df41 into moveit:ros2 May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants