Use modern cmake to fix compiling on ROS2 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ros2 #96 +/- ##
=======================================
Coverage 68.21% 68.21%
=======================================
Files 3 3
Lines 607 607
=======================================
Hits 414 414
Misses 193 193 Continue to review full report at Codecov.
|
vatanaksoytezer
approved these changes
Aug 4, 2021
tylerjw
approved these changes
Aug 4, 2021
JafarAbdi
changed the title
tylerjw
added a commit
to tylerjw/ros2_documentation
that referenced
this pull request
Aug 4, 2021
As @JafarAbdi pointed out in [this PR](moveit/srdfdom#96 (comment)) the _exports suffix is non-standard. `Targets` or `-targets` is used by gtest, fmt, and nlohmann_json. I copied the _exports suffix into the moveit2 repo and now regret it. It would be nice to use common conventions here so others don't make the same mistake.
audrow
pushed a commit
to ros2/ros2_documentation
that referenced
this pull request
Aug 26, 2021
As @JafarAbdi pointed out in [this PR](moveit/srdfdom#96 (comment)) the _exports suffix is non-standard. `Targets` or `-targets` is used by gtest, fmt, and nlohmann_json. I copied the _exports suffix into the moveit2 repo and now regret it. It would be nice to use common conventions here so others don't make the same mistake.
mergify bot
pushed a commit
to ros2/ros2_documentation
that referenced
this pull request
Aug 26, 2021
As @JafarAbdi pointed out in [this PR](moveit/srdfdom#96 (comment)) the _exports suffix is non-standard. `Targets` or `-targets` is used by gtest, fmt, and nlohmann_json. I copied the _exports suffix into the moveit2 repo and now regret it. It would be nice to use common conventions here so others don't make the same mistake. (cherry picked from commit 1c5fc42)
mergify bot
pushed a commit
to ros2/ros2_documentation
that referenced
this pull request
Aug 26, 2021
As @JafarAbdi pointed out in [this PR](moveit/srdfdom#96 (comment)) the _exports suffix is non-standard. `Targets` or `-targets` is used by gtest, fmt, and nlohmann_json. I copied the _exports suffix into the moveit2 repo and now regret it. It would be nice to use common conventions here so others don't make the same mistake. (cherry picked from commit 1c5fc42)
audrow
pushed a commit
to ros2/ros2_documentation
that referenced
this pull request
Aug 26, 2021
As @JafarAbdi pointed out in [this PR](moveit/srdfdom#96 (comment)) the _exports suffix is non-standard. `Targets` or `-targets` is used by gtest, fmt, and nlohmann_json. I copied the _exports suffix into the moveit2 repo and now regret it. It would be nice to use common conventions here so others don't make the same mistake. (cherry picked from commit 1c5fc42) Co-authored-by: Tyler Weaver <tylerjw@gmail.com>
audrow
pushed a commit
to ros2/ros2_documentation
that referenced
this pull request
Aug 26, 2021
As @JafarAbdi pointed out in [this PR](moveit/srdfdom#96 (comment)) the _exports suffix is non-standard. `Targets` or `-targets` is used by gtest, fmt, and nlohmann_json. I copied the _exports suffix into the moveit2 repo and now regret it. It would be nice to use common conventions here so others don't make the same mistake. (cherry picked from commit 1c5fc42) Co-authored-by: Tyler Weaver <tylerjw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: moveit/moveit2#588 (comment)