Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added License file #55

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Added License file #55

merged 3 commits into from
Feb 9, 2021

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Feb 8, 2021

Required to release the package ros/rosdistro#28250

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Feb 8, 2021
Comment on lines 9 to +10
<license>BSD</license>
<license>Apache License 2.0</license>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to add two LICENSE files (one for each package), instead of a LICENSE file in the root directory, since this package is BSD and the other is Apache 2.

Copy link
Collaborator Author

@ahcorde ahcorde Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files are Apache 2 except these two :

But they have changed a lot since I started to port this plugin. Does it make sense to change the License to Apache 2 too (because of the complete redesing)?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If OSRF was the only copyright holder, I'd say it would be fine to change the license.

In this case, I can't recommend changing the license because it's not clear to me how influential the the original files were in developing this version.

I think the easiest thing to do would be to either,

  1. License the entire package as BSD
  2. Keep it dual licensed (list both BSD and Apache 2 in the package.xml and list both in the license file

IMO, option one is the simplest, considering an prospective user perspective. I'm open to other suggestions though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: ahcorde <ahcorde@gmail.com>
LICENSE Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 95a5cbe into master Feb 9, 2021
@ahcorde ahcorde deleted the ahcorde/license branch February 9, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants