-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added License file #55
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
<license>BSD</license> | ||
<license>Apache License 2.0</license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to add two LICENSE files (one for each package), instead of a LICENSE file in the root directory, since this package is BSD and the other is Apache 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All files are Apache 2 except these two :
But they have changed a lot since I started to port this plugin. Does it make sense to change the License to Apache 2 too (because of the complete redesing)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If OSRF was the only copyright holder, I'd say it would be fine to change the license.
In this case, I can't recommend changing the license because it's not clear to me how influential the the original files were in developing this version.
I think the easiest thing to do would be to either,
- License the entire package as BSD
- Keep it dual licensed (list both BSD and Apache 2 in the package.xml and list both in the license file
IMO, option one is the simplest, considering an prospective user perspective. I'm open to other suggestions though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added BSD 3-Clause to the LICENSE file https://github.com/ros-simulation/gazebo_ros2_control/blob/7967bb7f957636315e48635d0774a6b2de96247a/LICENSE#L204-L234
dual License in the package.xml https://github.com/ros-simulation/gazebo_ros2_control/blob/7967bb7f957636315e48635d0774a6b2de96247a/gazebo_ros2_control/package.xml#L9-L10
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Required to release the package ros/rosdistro#28250
Signed-off-by: ahcorde ahcorde@gmail.com