gazebo_ros_api_plugin: improve plugin xml parsing when spawning model (lunar-devel) #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An xml comment that start with plugin causes a seg-fault: <!--plugin--> or <!--plugin filename="lib.so"/--> This fixes the xml parsing to not try to add child elements to xml comments.
|
@osrf-jenkins run tests please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ port of pull request #584 }
Spawning a model with an xml comment that starts with plugin causes a seg-fault:
<!--plugin-->or
<!--plugin filename="lib.so"/-->Checking the
Type()prevents trying to add child elements to xml comments, which is the source of the seg-fault. I also switched fromfindtocompareto make sure that only<plugin>blocks are affected instead of elements that start withpluginlike<plugin1>,<pluginCustom>, etc.It should be easy to add a test for this that just spawns some simple models with these xml tags added.
Here's the backtrace I was seeing: