reuse camera info in tests, rather than redfining in each method #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flova
approved these changes
Aug 19, 2022
ijnek
force-pushed
the
ijnek-reuse-cam-info
branch
from
6c86366
to
9b785f7
Compare
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
ijnek
force-pushed
the
ijnek-reuse-cam-info
branch
from
9b785f7
to
695c657
Compare
I said this in my previous comment, but I've changed my mind. I'm going to merge this to get it out of the way. I don't think the merge conflicts are going to be bad. |
…e tests only pass when there is an invalid camera info. Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tests a bit shorter and easier to understand.
I think the tests should pass once #37 is merged.