Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log JoyTeleopException #41

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Log JoyTeleopException #41

merged 1 commit into from
Dec 15, 2019

Conversation

youtalk
Copy link
Contributor

@youtalk youtalk commented Dec 13, 2019

Current joy_teleop.py implementation passes JoyTeleopException without any logging.
It might be difficult to debug config.yaml description.

This PR improves it.

@youtalk youtalk changed the base branch from kinetic-devel to dashing-devel December 13, 2019 05:26
bmagyar
bmagyar approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like that you reduced the scope of the try block

@bmagyar
Copy link
Member

bmagyar commented Dec 13, 2019

@artivis happy to chime in?

@artivis
Copy link
Contributor

artivis commented Dec 14, 2019

Left a small question, otherwise LGTM.

@bmagyar bmagyar merged commit 887aa75 into ros-teleop:dashing-devel Dec 15, 2019
@youtalk youtalk deleted the log-exception branch December 16, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@artivis artivis artivis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@youtalk @bmagyar @artivis