Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid halting on action server status checks. #48

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Avoid halting on action server status checks. #48

merged 1 commit into from
Feb 10, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Feb 4, 2020

This pull requests prevents the joy_teleop node from halting 0.5 sec every 2 sec in search for "online" action servers.

@hidmic
Avoid halting on action server status checks.
a9e27d8 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@bmagyar
Copy link
Member

bmagyar commented Feb 4, 2020

@artivis

@artivis
Copy link
Contributor

artivis commented Feb 6, 2020

Couldn't test it however the change is rather small and makes sense (server_is_ready doc for reference).
lgtm 👍

@hidmic
Copy link
Contributor Author

hidmic commented Feb 10, 2020

@artivis @bmagyar is this patch ready to go?

@bmagyar
Copy link
Member

bmagyar commented Feb 10, 2020

thanks for this, let's merge!

@bmagyar bmagyar merged commit 097d4f8 into ros-teleop:dashing-devel Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hidmic @bmagyar @artivis