Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to source ROS install for windows #306

Merged
merged 19 commits into from
Aug 19, 2020
Merged

try to source ROS install for windows #306

merged 19 commits into from
Aug 19, 2020

Conversation

flynneva
Copy link
Contributor

trying to resolve #305

@flynneva
Copy link
Contributor Author

i dont actually know if this change is necessary? I cant really tell how right now this action for windows finds if ROS is installed or not for windows.

@christophebedard christophebedard mentioned this pull request Aug 16, 2020
Closed
1 task
emersonknapp
emersonknapp reviewed Aug 18, 2020
View reviewed changes
src/action-ros-ci.ts Outdated Show resolved Hide resolved
@flynneva flynneva marked this pull request as draft August 18, 2020 04:39
@flynneva
Copy link
Contributor Author

flynneva commented Aug 18, 2020 •
edited
Loading

correctly sourcing the ros2 install from c:\dev\DISTRO\ros2-windows\setup.bat now....but still missing the rosdep update and rosdep install step due to rosdep not being supported yet for windows.

@flynneva flynneva marked this pull request as ready for review August 18, 2020 23:12
flynneva
flynneva commented Aug 18, 2020
View reviewed changes
src/action-ros-ci.ts Outdated Show resolved Hide resolved
flynneva
flynneva commented Aug 18, 2020
View reviewed changes
src/action-ros-ci.ts Outdated Show resolved Hide resolved
flynneva and others added 18 commits August 18, 2020 16:17
@flynneva
try to source ROS install for windows
f19a5f7 
trying to resolve #305

Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
add prefix to log message
b2ae92a 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
seeing if backslash was the problem
c4b51d9 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
try forward slashes for windows
df20d41 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
trying some logging
fdf45c6 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
built
cf6d389 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
trying to source ros for winows
94ca45b 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
still cant sourc ros on windows
03c9cb3 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
removed call cmd for windows
c4e3719 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
trying to fix filepath to ros setup file
0c6f2cf 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
.bat not .sh
0f3405d 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
added ros2-windows directory
eaeda4e 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
trying to run rosdep install
544dbf7 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
rosdep not supported on windows
97d7bc4 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@dependabot @flynneva
Bump @types/jest from 26.0.9 to 26.0.10
975d548 
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 26.0.9 to 26.0.10.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@types/jest&package-manager=npm_and_yarn&previous-version=26.0.9&new-version=26.0.10)](https://help.github.com/articles/configuring-automated-security-fixes)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@dependabot @flynneva
Bump @types/node from 14.0.27 to 14.6.0
3628dec 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.0.27 to 14.6.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@types/node&package-manager=npm_and_yarn&previous-version=14.0.27&new-version=14.6.0)](https://help.github.com/articles/configuring-automated-security-fixes)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
too many spaces
b6ae395 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
not enough spaces
9ff15a7 
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@emersonknapp emersonknapp merged commit 77cd680 into ros-tooling:master Aug 19, 2020
@flynneva flynneva deleted the patch-1 branch August 19, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard left review comments

@emersonknapp emersonknapp emersonknapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

specifying vcs-repo-file-url to "" for windows/mac causes failure
3 participants
@flynneva @emersonknapp @christophebedard