Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and re-write some sections #568

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Update README and re-write some sections #568

merged 1 commit into from
Mar 10, 2021

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Mar 6, 2021

This makes various small changes to the README:

  • fix codecov example/snippet
    • fixes Codecov in action-ros-ci does not work #562
    • codecov.yaml seems to have been renamed to codecov.yml
    • actions/checkout is needed for codecov/codecov-action to get codecov.yml
    • update/fix codecov.yml example
    • mention needing to provide CODECOV_TOKEN only for private repos
    • update codecov/codecov-action version
    • use 'coverage-pytest' mixin in snippet too
  • add table of contents for an easy overview of the README
  • split ament_copyright basic example into binary vs source build
    • this makes it obvious to users that there are 2 ways of using the action
    • use a generic package name instead of ament_copyright
  • uniformize snippets
    • remove use of actions/checkout when not needed
    • add steps: where needed so that snippets are complete-ish examples
  • fix use of if: always() in logs upload example
  • update commit used for colcon-mixin-repository
  • add codecov badge
  • make small fixes & rephrase & uniformize
  • move 'Developing' section to the bottom
    • since this does not really apply to most people looking at the README

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

@christophebedard christophebedard requested a review from a team as a code owner March 6, 2021 21:02
@christophebedard christophebedard requested review from Karsten1987 and jaisontj and removed request for a team March 6, 2021 21:02
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #568 (75bf3e6) into master (07b0bef) will decrease coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage   39.90%   38.96%   -0.94%     
==========================================
  Files           2        2              
  Lines         213      213              
  Branches       39       39              
==========================================
- Hits           85       83       -2     
- Misses        128      130       +2     
Impacted Files Coverage Δ
src/action-ros-ci.ts 29.34% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b0bef...a48a649. Read the comment docs.

@christophebedard
Copy link
Member Author

The dependabot badge seems broken. See dependabot/dependabot-core#1912 & dependabot/dependabot-core#1960.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the updates!

@emersonknapp emersonknapp enabled auto-merge (squash) March 8, 2021 18:07
@christophebedard
Copy link
Member Author

christophebedard commented Mar 8, 2021

We might want to wait until #570 is merged so that I can rebase on it and update the table of contents to add the new section from that PR.

Oh wait I can just add it now and see if there are any conflicts.

@emersonknapp
Copy link
Contributor

We might want to wait until #570 is merged so that I can rebase on it and update the table of contents to add the new section from that PR.

Oh wait I can just add it now and see if there are any conflicts.

I've enabled auto-merge on all of these PRs - they won't merge until they are up-to-date, pass tests, and have no merge conflicts - so you should have complete control over the order of operations now by updating branches in your chosen order

This makes various small changes to the README:

* fix codecov example/snippet
    * fixes #562
    * codecov.yaml seems to have been renamed to codecov.yml
    * actions/checkout is needed for codecov/codecov-action to get codecov.yml
    * update/fix codecov.yml example
    * mention needing to provide CODECOV_TOKEN only for private repos
    * update codecov/codecov-action version
    * use 'coverage-pytest' mixin in snippet too
* add table of contents for an easy overview of the README
* split ament_copyright basic example into binary vs source build
    * this makes it obvious to users that there are 2 ways of using the action
    * use a generic package name instead of ament_copyright
* uniformize snippets
    * remove use of actions/checkout when not needed
    * add `steps:` where needed so that snippets are complete-ish examples
* fix use of `if: always()` in logs upload example
* update commit used for colcon-mixin-repository
* add codecov badge
* make small fixes & rephrase & uniformize
* move 'Developing' section to the bottom
    * since this does not really apply to most people looking at the README

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@emersonknapp emersonknapp merged commit 64858bf into ros-tooling:master Mar 10, 2021
@christophebedard christophebedard deleted the update-readme branch March 10, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov in action-ros-ci does not work
2 participants