Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add colcon-defaults input #570

Merged
merged 4 commits into from
Mar 10, 2021
Merged

Add colcon-defaults input #570

merged 4 commits into from
Mar 10, 2021

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Mar 7, 2021 •
edited
Loading

Relates to #525, #526, #555

This adds a colcon-defaults input. The JSON content is validated and then written to ~/.colcon/defaults.yaml.

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

@christophebedard christophebedard requested a review from a team as a code owner March 7, 2021 19:19
@christophebedard christophebedard requested review from thomas-moulard and zmichaels11 and removed request for a team March 7, 2021 19:19
@codecov
Copy link

codecov bot commented Mar 7, 2021 •
edited
Loading

Codecov Report

Merging #570 (7ed1afa) into master (f846414) will decrease coverage by 3.45%.
The diff coverage is 5.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   42.42%   38.96%   -3.46%     
==========================================
  Files           2        2              
  Lines         198      213      +15     
  Branches       36       39       +3     
==========================================
- Hits           84       83       -1     
- Misses        114      130      +16
Impacted Files Coverage Δ
src/action-ros-ci.ts 29.34% <5.55%> (-3.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f846414...8054bdd. Read the comment docs.

emersonknapp
emersonknapp reviewed Mar 8, 2021
View reviewed changes
src/action-ros-ci.ts Outdated Show resolved Hide resolved
@christophebedard christophebedard mentioned this pull request Mar 8, 2021
Merged
emersonknapp
emersonknapp approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better - thanks

@emersonknapp emersonknapp enabled auto-merge (squash) March 8, 2021 21:14
@ddengster ddengster mentioned this pull request Mar 9, 2021
Merged
@christophebedard
Add colcon-defaults input
ec8c011 
Relates to #525, #526, #555

This adds a `colcon-defaults` input. The JSON content is validated and then
written to `~/.colcon/defaults.yaml`.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Use COLCON_DEFAULTS_FILE instead
67d2858 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Set vcs-repo-file-url for test_colcon_defaults
3930af9 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Set required-ros-distributions in colcon-defaults example
8054bdd 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@emersonknapp emersonknapp merged commit 07b0bef into ros-tooling:master Mar 10, 2021
@christophebedard christophebedard deleted the add-colcon-defaults-input branch March 10, 2021 01:03
@christophebedard christophebedard mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@thomas-moulard thomas-moulard Awaiting requested review from thomas-moulard

@zmichaels11 zmichaels11 Awaiting requested review from zmichaels11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophebedard @emersonknapp