Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test images from ros-tooling/setup-ros-docker#{73,74} #871

Conversation

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard self-assigned this May 17, 2024
@christophebedard christophebedard requested a review from a team as a code owner May 17, 2024 15:02
@christophebedard christophebedard requested review from gbiggs and MichaelOrlov and removed request for a team May 17, 2024 15:02
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.40%. Comparing base (8cf3d2d) to head (59d4445).
Report is 2 commits behind head on master.

Current head 59d4445 differs from pull request most recent head 91a7009

Please upload reports for the commit 91a7009 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #871       +/-   ##
===========================================
- Coverage   45.54%   26.40%   -19.15%     
===========================================
  Files           2        2               
  Lines         303      303               
  Branches       81       81               
===========================================
- Hits          138       80       -58     
- Misses        165      223       +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 59d4445.

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard changed the title Test images from ros-tooling/setup-ros-docker#73 Test images from ros-tooling/setup-ros-docker#{73,74} May 17, 2024
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard force-pushed the christophebedard/test-setup-ros-docker-images-apt branch from 3afddda to 91a7009 Compare May 17, 2024 19:03
@MichaelOrlov
Copy link
Member

@christophebedard Could you please put more info or context about what is it?
I don't quite get it. Why do we need these changes, and what are they for?

@christophebedard
Copy link
Member Author

christophebedard commented May 17, 2024

Like the PR title says, this was just to test images from ros-tooling/setup-ros-docker#73 and ros-tooling/setup-ros-docker#74. This is not a change. Closing now.

@christophebedard christophebedard deleted the christophebedard/test-setup-ros-docker-images-apt branch May 17, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants