Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add void annotation (#194) #195

Merged
merged 1 commit into from
May 24, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 18, 2024

@wep21 wep21 requested a review from a team as a code owner May 18, 2024 06:33
@wep21 wep21 requested review from gbiggs and christophebedard and removed request for a team May 18, 2024 06:33
@christophebedard
Copy link
Member

This looks good to me, but it looks like jazzy branches are frozen now, so this will have to wait a bit: https://discourse.ros.org/t/upcoming-freeze-for-jazzy-in-preparation-for-release/37828

@christophebedard
Copy link
Member

Can you rebase on jazzy?

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (jazzy@94ad02b). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             jazzy     #195   +/-   ##
========================================
  Coverage         ?   24.35%           
========================================
  Files            ?       67           
  Lines            ?     5382           
  Branches         ?      663           
========================================
  Hits             ?     1311           
  Misses           ?     3976           
  Partials         ?       95           
Flag Coverage Δ
unittests 24.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wep21
Copy link
Contributor Author

wep21 commented May 24, 2024

@christophebedard rebased!

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit 88c80dd into ros-tooling:jazzy May 24, 2024
13 checks passed
@wep21 wep21 deleted the backport-194-jazzy branch May 24, 2024 22:59
@wep21
Copy link
Contributor Author

wep21 commented Jun 23, 2024

@christophebedard I appreciate it if you could create a new release for jazzy.

@christophebedard
Copy link
Member

Done! It will be released into Jazzy as 1.7.3: ros/rosdistro#41783.

However, I do not know when it will be available in the main apt repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants