Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Doxyfile #23

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 7, 2020

Added Doxyfile to include this package as part of the ROS 2 public API, available at docs.ros2.org.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   25.43%   25.43%           
=======================================
  Files          26       26           
  Lines         798      798           
  Branches      185      185           
=======================================
  Hits          203      203           
  Misses        432      432           
  Partials      163      163           
Flag Coverage Δ
#unittests 25.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25cf0d8...5a74ded. Read the comment docs.

@thomas-moulard
Copy link
Member

@ahcorde How did you validate this is working?

@ahcorde
Copy link
Contributor Author

ahcorde commented May 11, 2020

you can just simply run inside the libstatistics_collector package and the open in a browser doc_output/html/index.html :

doxygen Doxyfile

But I'm integrating many packages in this repo https://github.com/ros2/docs.ros2.org which it's the one on charge of generate the documentation. PR to the repo is on the way

@ahcorde
Copy link
Contributor Author

ahcorde commented May 11, 2020

I don't have write permissions here. can you merge it?

@thomas-moulard
Copy link
Member

you can just simply run inside the libstatistics_collector package and the open in a browser doc_output/html/index.html :

doxygen Doxyfile

But I'm integrating many packages in this repo https://github.com/ros2/docs.ros2.org which it's the one on charge of generate the documentation. PR to the repo is on the way

Thanks, I'll try that! Do you have any doc about how to maintain this file? I'd like to understand when/how we should update it? Seems like it's only including the README.md now?

Comment on lines +23 to +25
TAGFILES += "../../../../doxygen_tag_files/cppreference-doxygen-web.tag.xml=http://en.cppreference.com/w/"
TAGFILES += "../../../../doxygen_tag_files/rcl.tag=http://docs.ros2.org/latest/api/rcl/"
TAGFILES += "../../../../doxygen_tag_files/rcpputils.tag=http://docs.ros2.org/latest/api/rcpputils/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should we change those?

TAGFILES += "../../../../doxygen_tag_files/rcl.tag=http://docs.ros2.org/latest/api/rcl/"
TAGFILES += "../../../../doxygen_tag_files/rcpputils.tag=http://docs.ros2.org/latest/api/rcpputils/"
# Uncomment to generate tag files for cross-project linking.
GENERATE_TAGFILE = "../../../../doxygen_tag_files/libstatistics_collector.tag"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here?

@thomas-moulard
Copy link
Member

Merging as this worked, @ahcorde if you could teach us (or write some doc?) about what we're expected to do with this file in the future, that'd be great.

@thomas-moulard thomas-moulard merged commit a2a5dd9 into ros-tooling:master May 11, 2020
@dabonnie
Copy link
Contributor

@thomas-moulard this could be interesting, I'll take a look at it later: https://github.com/marketplace/actions/doxygen-action

@thomas-moulard
Copy link
Member

thomas-moulard commented May 11, 2020

Nice! Let's see what @ahcorde come up with. That should be fairly similar to how docs.ros2.org is populated. Maybe we could use the action in PRs though to ensure the Doxyfile is still valid?

@dabonnie
Copy link
Contributor

Maybe we could use the action in PRs though to ensure the Doxyfile is still valid?

My thought exactly. We would at least have local generation to manually review changes, etc.

@ahcorde
Copy link
Contributor Author

ahcorde commented May 13, 2020

Sorry for the late response,

Doxygen and Sphinx are generated using this script. We manually run it right now. Probably it makes sense to create a package similar to this one https://github.com/ros-infrastructure/rosdoc_lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants