Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export targets in a addition to include directories / libraries #8

Merged
merged 1 commit into from
Apr 23, 2020
Merged

export targets in a addition to include directories / libraries #8

merged 1 commit into from
Apr 23, 2020

Conversation

dirk-thomas
Copy link
Contributor

Related to ros2/ros2#904.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #8 into master will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   24.72%   25.40%   +0.67%     
==========================================
  Files          28       26       -2     
  Lines         829      807      -22     
  Branches      188      188              
==========================================
  Hits          205      205              
+ Misses        457      435      -22     
  Partials      167      167              
Flag Coverage Δ
#unittests 25.40% <ø> (+0.67%) ⬆️
Impacted Files Coverage Δ
...tics_collector/msg/dummy_message__type_support.cpp
...istics_collector/msg/dummy_message__type_support.c

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3751e8...74a6b46. Read the comment docs.

@dirk-thomas
Copy link
Contributor Author

dirk-thomas commented Apr 23, 2020

Maybe someone with knowledge about the GitHub actions in this repo can clarify what the failure is about?

Also triggering a current build for the target branch (not the one from the latest commit which is 5 days old) could help determining if the problem is already present on the target branch or introduced by this patch.

Copy link
Member

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabonnie
Copy link
Contributor

Maybe someone with knowledge about the GitHub actions in this repo can clarify what the failure is about?

Also triggering a current build for the target branch (not the one from the latest commit which is 5 days old) could help determining if the problem is already present on the target branch or introduced by this patch.

The failure with OSX is present in master, so not introduced via this PR. We're tracking the issue here and I suspect it's something missing in https://github.com/ros-tooling/setup-ros, but need more data.

Will move forward with this and merge.

@dabonnie dabonnie merged commit 741dce3 into ros-tooling:master Apr 23, 2020
@dirk-thomas dirk-thomas deleted the dirk-thomas/export-targets branch April 23, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants