This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Store IDL definitions in MCAP #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-rms
force-pushed
the
jrms/store_idl_definitions
branch
3 times, most recently
from
1df1b93
to
762c1ad
Compare
james-rms
commented
Sep 5, 2022
rosbag2_storage_mcap/include/rosbag2_storage_mcap/message_definition_cache.hpp
Show resolved
Hide resolved
james-rms
commented
Sep 5, 2022
james-rms
force-pushed
the
jrms/store_idl_definitions
branch
2 times, most recently
from
b613788
to
25d31b9
Compare
|
Can a |
|
You're right, it can, and this code doesn't handle that (it'll fail with "file not found"). I can take a look at falling back to IDL if any dependency has no MSG definition. |
james-rms
force-pushed
the
jrms/store_idl_definitions
branch
from
0680797
to
1d12471
Compare
|
@emersonknapp ok, handled and tested. |
james-rms
force-pushed
the
jrms/store_idl_definitions
branch
3 times, most recently
from
d2da862
to
193c41b
Compare
emersonknapp
approved these changes
Sep 7, 2022
james-rms
force-pushed
the
jrms/store_idl_definitions
branch
2 times, most recently
from
0369c54
to
32caf1d
Compare
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
jrms/store_idl_definitions
branch
from
b22a16f
to
942d1e9
Compare
james-rms
added a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 18, 2022
Adds logic to detect IDL-defined message types and store the IDL. Signed-off-by: James Smith <james@foxglove.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to detect IDL-defined message types and store the IDL.