Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Python setup for windows #159

Merged
merged 3 commits into from
May 9, 2020
Merged

Conversation

rotu
Copy link
Contributor

@rotu rotu commented May 8, 2020

Find Python using tool-cache.
Find Python directories using sysconfig.

Fixes #156

Signed-off-by: Dan Rose dan@digilabs.io

@rotu rotu mentioned this pull request May 8, 2020
@rotu rotu force-pushed the win-python branch 2 times, most recently from 09e9c5a to 84cbdb6 Compare May 8, 2020 03:11
@rotu rotu changed the title Use python3 to get configuration options Use python to get paths May 8, 2020
@rotu rotu force-pushed the win-python branch 7 times, most recently from f4132ea to 32bb2ea Compare May 9, 2020 00:56
Find Python using tool-cache.
Find Python directories using sysconfig.

Signed-off-by: Dan Rose <dan@digilabs.io>
@rotu rotu changed the title Use python to get paths Better Python setup for windows May 9, 2020
@rotu rotu marked this pull request as ready for review May 9, 2020 01:07
@thomas-moulard thomas-moulard merged commit 52b8ac3 into ros-tooling:master May 9, 2020
@rotu rotu deleted the win-python branch May 9, 2020 16:19
rotu added a commit to ros2/rmw_cyclonedds that referenced this pull request May 12, 2020
Master has build-fixing changes for compatibility with the GitHub Windows runner since ros-tooling/setup-ros#159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Don't hardcode python version/path
2 participants