Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Dabonnie/fix cpu measurement test #102

Merged
merged 3 commits into from Mar 4, 2020

Conversation

dabonnie
Copy link
Contributor

@dabonnie dabonnie commented Mar 3, 2020

Closes #83

Blocked by #101

Uses the work in #100 in order to refactor Linux CPU measurement tests

Signed-off-by: Devin Bonnie dbbonnie@amazon.com

@dabonnie dabonnie self-assigned this Mar 3, 2020
@dabonnie
Copy link
Contributor Author

dabonnie commented Mar 3, 2020

Marking as draft until sufficient test repeats are accomplished. Currently running via
./test_linux_cpu_measurement_node --gtest_repeat=-1 --gtest_break_on_failure

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #102 into master will decrease coverage by 0.07%.
The diff coverage is 16.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   39.33%   39.26%   -0.08%     
==========================================
  Files          37       37              
  Lines        1482     1444      -38     
  Branches      890      869      -21     
==========================================
- Hits          583      567      -16     
  Misses         70       70              
+ Partials      829      807      -22
Flag Coverage Δ
#unittests 39.26% <16.39%> (-0.08%) ⬇️
Impacted Files Coverage Δ
...r/test/system_metrics_collector/test_functions.hpp 50.87% <ø> (ø) ⬆️
...lector/test_linux_process_cpu_measurement_node.cpp 35.89% <0%> (ø) ⬆️
...m_metrics_collector/test_linux_cpu_measurement.cpp 18.42% <16.36%> (-5.93%) ⬇️
...etrics_collector/test_linux_memory_measurement.cpp 20.86% <20%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e0cca...4d66a5c. Read the comment docs.

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@dabonnie dabonnie force-pushed the dabonnie/fix-cpu-measurement-test branch from fbe910d to 64178b0 Compare March 3, 2020 23:59
@dabonnie dabonnie marked this pull request as ready for review March 3, 2020 23:59
@dabonnie
Copy link
Contributor Author

dabonnie commented Mar 4, 2020

1200 repeated tests and no failures

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@dabonnie dabonnie merged commit 88380ee into master Mar 4, 2020
@dabonnie dabonnie deleted the dabonnie/fix-cpu-measurement-test branch March 4, 2020 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinuxCpuMeasurementTestFixture.TestManualMeasurement test failure
3 participants