This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marking as draft until sufficient test repeats are accomplished. Currently running via |
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 39.33% 39.26% -0.08%
==========================================
Files 37 37
Lines 1482 1444 -38
Branches 890 869 -21
==========================================
- Hits 583 567 -16
Misses 70 70
+ Partials 829 807 -22
Continue to review full report at Codecov.
|
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
dabonnie
force-pushed
the
dabonnie/fix-cpu-measurement-test
branch
from
March 3, 2020 23:59
fbe910d
to
64178b0
Compare
|
zmichaels11
suggested changes
Mar 4, 2020
system_metrics_collector/test/system_metrics_collector/test_constants.hpp
Show resolved
Hide resolved
system_metrics_collector/test/system_metrics_collector/test_linux_memory_measurement.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
zmichaels11
approved these changes
Mar 4, 2020
system_metrics_collector/test/system_metrics_collector/test_linux_cpu_measurement.cpp
Show resolved
Hide resolved
system_metrics_collector/test/system_metrics_collector/test_linux_memory_measurement.cpp
Show resolved
Hide resolved
prajakta-gokhale
approved these changes
Mar 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
Blocked by #101
Uses the work in #100 in order to refactor Linux CPU measurement tests
Signed-off-by: Devin Bonnie dbbonnie@amazon.com