This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Refactor Linux memory measurement tests #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
dabonnie
commented
Feb 29, 2020
| "MemTotal: 16304208 kB\n" | ||
| "MemFree: 827568 kB\n" | ||
| "MemAvailable: 4838060 kB\n", | ||
| ExpectedStatistics StatisticDataToExpectedStatistics(const StatisticData & src) |
There was a problem hiding this comment.
This can be moved to test_utilities
|
The continuous gtests exited with this failure: |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 39.33% 39.36% +0.02%
==========================================
Files 36 36
Lines 1449 1481 +32
Branches 869 889 +20
==========================================
+ Hits 570 583 +13
- Misses 66 69 +3
- Partials 813 829 +16
Continue to review full report at Codecov.
|
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
piraka9011
reviewed
Mar 2, 2020
| ASSERT_EQ(State::PRIMARY_STATE_ACTIVE, test_measure_linux_memory_->get_current_state().id()); | ||
| ASSERT_TRUE(test_measure_linux_memory_->IsStarted()); | ||
|
|
||
| // |
There was a problem hiding this comment.
nit: extra comment line?
piraka9011
approved these changes
Mar 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
This refactor uses futures in order to wait for asynchronous events, instead of making strict time assumptions. Note that the unit test no longer tests for multiple received messages, but this PR adds this check to e2e testing: #98
Marking as draft as test documentation is currently needed. Note that this test was run for >7000 times without failure using
./test_linux_memory_measurement_node --gtest_repeat=-1 --gtest_break_on_failure.Signed-off-by: Devin Bonnie dbbonnie@amazon.com