Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows warnings #71

Merged
merged 4 commits into from Jul 7, 2023
Merged

Fix windows warnings #71

merged 4 commits into from Jul 7, 2023

Conversation

emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp requested a review from a team as a code owner July 6, 2023 22:03
christophebedard
christophebedard approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI (at least local GitHub CI for Linux).

@emersonknapp
Copy link
Contributor Author

I'll run full ci.ros2.org on this to actually look for greens across the board, then can backport and make sure Humble/Iron also all greens, then will cut releases with the new branches

@emersonknapp
Fix windows warnings
08a0c3d 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
ConstSharedPtr everywhere
f1eaf57 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jul 6, 2023 •
edited

Pulls: #71
Gist: https://gist.githubusercontent.com/emersonknapp/64914eb5816cc95ae84edff9be760aac/raw/e985fc1b6d3ddc0aa3a43345a47c76e4d523498b/ros2.repos
BUILD args: --packages-above-and-dependencies topic_tools
TEST args: --packages-above topic_tools
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12337

  • Linux Build Status
    • Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp
Be more explicit about int64_t to fix windows warning
f1ff3f3 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jul 7, 2023 •
edited

Rebuild above

  • Linux Build Status
    • Build Status
    • Build Status
  • Linux-aarch64 Build Status
    • Build Status
  • Windows Build Status

@emersonknapp
Add in one more cast because sometimes int literals are weird?
5f7f88f 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Contributor Author

  • Windows Build Status

@emersonknapp emersonknapp merged commit e161666 into main Jul 7, 2023
11 checks passed
@emersonknapp emersonknapp deleted the fix-windows-warnings branch July 7, 2023 16:21
@emersonknapp
Copy link
Contributor Author

@Mergifyio backport humble iron

@mergify
Copy link

mergify bot commented Jul 7, 2023 •
edited

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 7, 2023
@emersonknapp @mergify
Fix windows warnings (#71)
35ecda8 
* Fix windows warnings

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit e161666)
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
@emersonknapp @mergify
Fix windows warnings (#71)
eb331ad 
* Fix windows warnings

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit e161666)
This was referenced Jul 7, 2023
Merged
Merged
emersonknapp pushed a commit that referenced this pull request Jul 7, 2023
@mergify
Fix windows warnings (backport #71) (#73)
cad748b 
* Fix windows warnings

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp added a commit that referenced this pull request Jul 27, 2023
@mergify @emersonknapp
Fix windows warnings (#71) (#74)
c17b03a 
* Fix windows warnings

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit e161666)

Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros-tooling/reviewers

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros-tooling/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emersonknapp @christophebedard