Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional degrees of freedom (YZ) to linear interactive markers. #7

Merged

Conversation

tonybaltovski
Copy link
Contributor

No description provided.

@mikepurvis
Copy link
Member

Thanks for this. My only concern is the use of "holonomic" to describe allowing linear movement in Y and Z. This isn't really holonomic, especially when you consider some of the other control schemes that are possible using marker configurations (eg).

I think just offering an X arrow and Y arrow is probably what's right for our needs for the moment, but I'm wondering if there's another way to name it?

@tonybaltovski
Copy link
Contributor Author

The holonomic would have X, Y and Yaw whereas the aerial would have X, Y, Z and Yaw.

@@ -0,0 +1,5 @@
<launch>
<node pkg="interactive_marker_twist_server" type="marker_server" name="twist_marker_server">
<rosparam command="load" file="$(find interactive_marker_twist_server)/config/aerial.yaml" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than creating multiple files here, just use an $(arg config) with a sensible default. (perhaps create a diffdrive.yaml or something)

@tonybaltovski
Copy link
Contributor Author

Tested this using the planar config with the Ridgeback.

@mikepurvis
Copy link
Member

LGTM, thanks.

@mikepurvis mikepurvis merged commit 75dac70 into ros-visualization:indigo-devel Jun 20, 2016
@tonybaltovski tonybaltovski deleted the add-linear-dofs branch June 20, 2016 18:48
@tonybaltovski
Copy link
Contributor Author

Care to do a release and a kinetic release as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants