Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake/sip_configure.py calls non standard 'qmake-qt4' #22

Closed
aballier opened this issue Apr 29, 2015 · 5 comments
Closed

cmake/sip_configure.py calls non standard 'qmake-qt4' #22

aballier opened this issue Apr 29, 2015 · 5 comments

Comments

@aballier
Copy link

python_qt_binding has been fixed for recent pyqt versions, thanks for that, however it has been done in a way that calls 'qmake-qt4' (instead of just 'qmake') which seems to be an invention of some distributions ( seen e.g. on https://wiki.archlinux.org/index.php/Qt#Installation and https://wiki.archlinux.org/index.php/Qt#Default_Qt_toolkit ) and that I don't have.

I am not sure how this should be fixed, archlinux wiki mentions a QT_SELECT environment variable, so maybe just calling 'qmake' with this variable set would work.

@dirk-thomas
Copy link
Contributor

Since this seems to be specific to whatever system you are using (and I have no way to check / confirm if a change works for you) can you please try your proposed change and report back if it works?

Providing a PR for hit would be highly appreciated and likely speed up the process 😉

@aballier
Copy link
Author

aballier commented May 4, 2015

I'm already patching it locally to replace 'qmake-qt4' with 'qmake' and it seems to work perfectly. What I'm not sure is if this doesn't break other systems :/

@dirk-thomas
Copy link
Contributor

Related to a recent change: #13

On ubuntu the dependency qt4-qmake depends on qtchooser which will bring in qmake. So it should be fine on Ubuntu. I have created PR #23 to address it.

@bchretien Can you please double check that it still works for you with the PR applied?

@bchretien
Copy link

$ qmake -v
QMake version 3.0
Using Qt version 5.4.1 in /usr/lib
$ QT_SELECT=4 qmake -v
QMake version 2.01a
Using Qt version 4.8.6 in /usr/lib

Looks good to me.

@dirk-thomas
Copy link
Contributor

@bchretien Thank you for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants