-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyQt 4.11 compatibility #15
Conversation
For more information, refer to ros-visualization/python_qt_binding#13 and ros-visualization/python_qt_binding#15
"pyqt_version_str": QtCore.PYQT_VERSION_STR, | ||
"pyqt_bin_dir": PyQt4.__path__[0], | ||
"pyqt_mod_dir": PyQt4.__path__[0], | ||
"pyqt_sip_dir": "/usr/share/sip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails on Arch. /usr/share/sip
contains several directories:
Py2-PyQt4
Py2-PyQt5
PyQt4
PyQt5
Qwt5
I had to set "pyqt_sip_dir"
to "/usr/share/sip/Py2-PyQt4"
to fix the compilation of rviz.
cc @v01d
Note: this PR aims at solving #13. |
/usr/share/sip/PyQt4 is what's used by Ubuntu Utopic, so I've updated the path to that. |
If I'm not mistaken, I guess that if this is the only part really specific for Arch, I can just keep a good ol' |
But as you said on the AUR, if sip files in /usr/share/*PyQt4 are identical, this could be solved in Arch's PyQt4 package. |
Superseded by #21. |
Starting in PyQt 4.11, there is no pyqtconfig, so this patch imitates it when its not found.
pyqtconfig.QtGuiModuleMakefile simply calls sipconfig.SIPModuleMakefile with qt=['QtCore', 'QtGui'],
thus this patches has no effect if pyqtconfig is found (i.e. if the user has PyQt <=4.10)