Fixes failing framework detection on OSX #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 27, 2016 12:58
Apparently the framework detection on OSX does not work properly if installed in a non standard location like /usr/local/Cellar/... As Homebrew by default installs Qt5 modules as frameworks this probably does not harm.
qt5 needs c++11, so sip generated bindings that depend on qt need to be build with c++11 as well
|
This would need to be tested on Linux, but it looks ok for mac. @dirk-thomas I'll let you decide what to do about this and when to merge it. @smits it would be helpful to post the exact error message, so others searching for this issue can find it through google. |
|
This has been reported in https://gist.github.com/plusk01/bb92f6159c0818000865784abfd2a584#qt_qui_cpp https://gist.github.com/plusk01/bb92f6159c0818000865784abfd2a584#rviz. @wjwwood You want me to test this on Linux? Do you have a specific configuration in mind? |
|
That would be good. I don't have anything specific in mind, builds and runs on Xenial (since this Kinetic). |
|
And by runs I mean |
|
Thanks for pickit this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the framework detection on OSX does not work properly if installed in a non standard location like /usr/local/Cellar/... As Homebrew by default installs Qt5 modules as frameworks and the variable isn't used on Linux and Windows base systems, this probably does not harm.