make another test more flexible in terms of whitespaces #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not appear to fix the CentOS-related issue: https://ci.ros2.org/job/ci_linux-centos/42/testReport/qt_dotgraph.test.pygraphviz_factory_test/PygraphvizFactoryTest/test_create_dot/ I believe the problem is that the newer graphviz puts "" in for the digraph name even when one is not specified, while the older version in CentOS does not have the empty double-quotes. |
dirk-thomas
force-pushed
the
dirk-thomas/whitespace-agnostic-test2
branch
from
9a358b5
to
cec05ba
Compare
|
I actually forgot that we have a CentOS CI job as well 😉 With the latest commit it passes: |
cottsay
approved these changes
Oct 24, 2019
dirk-thomas
added a commit
that referenced
this pull request
Oct 24, 2019
* make another test more flexible in terms of whitespaces * and more
dirk-thomas
added a commit
that referenced
this pull request
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #191.
@cottsay Since this only fails on CentOS (https://ci.ros2.org/view/nightly/job/nightly_linux-centos_debug/207/testReport/(root)/projectroot/qt_dotgraph/) can you please try this patch and comment if it resolves the failing test.